Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Issue 70453002: Don't write generated C++ bindings twice, only once. (Closed)

Created:
7 years, 1 month ago by Bill Hesse
Modified:
7 years, 1 month ago
Reviewers:
kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Don't write generated C++ bindings twice, only once. R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=30198

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M tools/dom/scripts/dartdomgenerator.py View 2 chunks +2 lines, -1 line 0 comments Download
M tools/dom/scripts/logging.conf View 2 chunks +7 lines, -1 line 0 comments Download
M tools/dom/scripts/systemnative.py View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 1 month ago (2013-11-12 17:10:49 UTC) #1
kustermann
LGTM
7 years, 1 month ago (2013-11-12 17:15:03 UTC) #2
Bill Hesse
7 years, 1 month ago (2013-11-12 17:16:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30198 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698