Report HintCode.UNUSED_ELEMENT for classes.

Report HintCode.UNUSED_ELEMENT for classes.

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=41650

[Brian Wilkerson, 2014-11-10 23:34:47]

LGTM. Are private methods next?

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element.dart:8814: static const Modifier IS_USED
= const Modifier('IS_USED', 10);
This might be less misleading if it were named IS_USED_IN_LIBRARY. I'm not sure
whether it's worth bothering with, though. Your call.

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element_resolver.dart:1908: void
_markElementUsed(Element element) {
This seems overly complex. Would it be sufficient to only check that the library
is the same? If so, would it be less efficient?

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:1924:
UnusedLocalVariableVerifier(this._errorReporter);
If the class is checking more than local variables we should rename it.

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/resolver_test.dart:3288: assertErrors(source, []);
Either use assertNoErrors or assertErrors with only the first argument.

[scheglov, 2014-11-11 02:57:06]

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element.dart (right):

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element.dart:8814: static const Modifier IS_USED
= const Modifier('IS_USED', 10);
On 2014/11/10 23:34:47, Brian Wilkerson wrote:
> This might be less misleading if it were named IS_USED_IN_LIBRARY. I'm not
sure
> whether it's worth bothering with, though. Your call.

Done.

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/element_resolver.dart (right):

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/element_resolver.dart:1908: void
_markElementUsed(Element element) {
On 2014/11/10 23:34:47, Brian Wilkerson wrote:
> This seems overly complex. Would it be sufficient to only check that the
library
> is the same? If so, would it be less efficient?

Done.

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/resolver.dart:1924:
UnusedLocalVariableVerifier(this._errorReporter);
On 2014/11/10 23:34:47, Brian Wilkerson wrote:
> If the class is checking more than local variables we should rename it.

Done.

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/test/generated/...
File pkg/analyzer/test/generated/resolver_test.dart (right):

https://codereview.chromium.org/704413005/diff/1/pkg/analyzer/test/generated/...
pkg/analyzer/test/generated/resolver_test.dart:3288: assertErrors(source, []);
On 2014/11/10 23:34:47, Brian Wilkerson wrote:
> Either use assertNoErrors or assertErrors with only the first argument.

Done.

[scheglov, 2014-11-11 02:57:31]

Committed patchset #2 (id:20001) manually as 41650 (presubmit successful).