Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 70433003: Filter only .html files in web, keep those in lib/. This is as a temporary (Closed)

Created:
7 years, 1 month ago by Siggi Cherem (dart-lang)
Modified:
7 years, 1 month ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Filter only .html files in web, keep those in lib/. This is as a temporary solution for dartbug.com/15038. Once dartbug.com/14187 is fixed, we can remove this extra check. Note: because anything in lib/ is copied under build/packages/foo, I noticed that the editor will not display any warnings there (they are considered the same as warning from other packages). So even with this new filter, we still achive our goal of keeping the build output warning free. R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=30216

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M pkg/polymer/lib/src/build/build_filter.dart View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-11-13 02:18:11 UTC) #1
Jennifer Messerly
lgtm
7 years, 1 month ago (2013-11-13 02:20:11 UTC) #2
Siggi Cherem (dart-lang)
7 years, 1 month ago (2013-11-13 02:25:22 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30216 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698