Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 704053002: Fix dart2js tests in pub. (Closed)

Created:
6 years, 1 month ago by nweiz
Modified:
6 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix dart2js tests in pub. Pub's [requestShouldSucceed] test helper didn't verify that the request returned a 200 response, which was masking some issues. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=41541

Patch Set 1 #

Total comments: 1

Messages

Total messages: 4 (0 generated)
nweiz
6 years, 1 month ago (2014-11-06 01:17:33 UTC) #1
Bob Nystrom
Is removing analyze-all a breaking change? Otherwise, LGTM. https://codereview.chromium.org/704053002/diff/1/sdk/lib/_internal/pub/test/dart2js/minify_configuration_overrides_mode_test.dart File sdk/lib/_internal/pub/test/dart2js/minify_configuration_overrides_mode_test.dart (right): https://codereview.chromium.org/704053002/diff/1/sdk/lib/_internal/pub/test/dart2js/minify_configuration_overrides_mode_test.dart#newcode21 sdk/lib/_internal/pub/test/dart2js/minify_configuration_overrides_mode_test.dart:21: ]) ...
6 years, 1 month ago (2014-11-06 01:32:35 UTC) #2
nweiz
> Is removing analyze-all a breaking change? Since it disables any actual dart2js output, I ...
6 years, 1 month ago (2014-11-06 01:39:48 UTC) #3
nweiz
6 years, 1 month ago (2014-11-06 01:40:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41541 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698