Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 703773004: Add parser recovery tests (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add parser recovery tests. These correspond to some cases that dart2js is currently handling that I wanted to make sure we also handled. R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=41652

Patch Set 1 #

Patch Set 2 : Improved test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -1 line) Patch
M pkg/analyzer/test/generated/parser_test.dart View 1 7 chunks +39 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-10 22:27:41 UTC) #2
Paul Berry
lgtm
6 years, 1 month ago (2014-11-10 23:22:01 UTC) #3
Brian Wilkerson
6 years, 1 month ago (2014-11-11 03:46:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41652 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698