Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 703693002: Regularize some naming to make BUILD.gn files easier to write. (Closed)

Created:
6 years, 1 month ago by zra
Modified:
6 years, 1 month ago
Reviewers:
siva, Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Regularize naming to make BUILD.gn files easier to write. Committed: https://code.google.com/p/dart/source/detail?r=41510

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -160 lines) Patch
M runtime/bin/bin.gypi View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/builtin.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/builtin.cc View 1 chunk +1 line, -1 line 0 comments Download
A + runtime/lib/core_sources.gypi View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D runtime/lib/corelib_sources.gypi View 1 1 chunk +0 lines, -62 lines 0 comments Download
M runtime/vm/bootstrap.h View 2 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/bootstrap.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + runtime/vm/bootstrap_nocore.cc View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D runtime/vm/bootstrap_nocorelib.cc View 1 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/vm/dart.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/vm.gypi View 1 11 chunks +26 lines, -26 lines 0 comments Download
A + sdk/lib/core/core_sources.gypi View 1 0 chunks +-1 lines, --1 lines 0 comments Download
D sdk/lib/core/corelib_sources.gypi View 1 1 chunk +0 lines, -43 lines 0 comments Download
M utils/apidoc/docgen.gyp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
zra
6 years, 1 month ago (2014-11-04 17:24:05 UTC) #2
Ivan Posva
LGTMwC -ip https://codereview.chromium.org/703693002/diff/1/runtime/vm/vm.gypi File runtime/vm/vm.gypi (right): https://codereview.chromium.org/703693002/diff/1/runtime/vm/vm.gypi#newcode430 runtime/vm/vm.gypi:430: 'target_name': 'generate_corelib_cc_file', corelib -> core Here and ...
6 years, 1 month ago (2014-11-04 18:03:16 UTC) #3
zra
https://codereview.chromium.org/703693002/diff/1/runtime/vm/vm.gypi File runtime/vm/vm.gypi (right): https://codereview.chromium.org/703693002/diff/1/runtime/vm/vm.gypi#newcode430 runtime/vm/vm.gypi:430: 'target_name': 'generate_corelib_cc_file', On 2014/11/04 18:03:16, Ivan Posva wrote: > ...
6 years, 1 month ago (2014-11-04 22:03:42 UTC) #4
zra
6 years, 1 month ago (2014-11-04 22:04:07 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as r41510 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698