Add RawReceivePort to dart2js.

Add RawReceivePort to dart2js.

BUG= http://dartbug.com/14456
R=floitsch@google.com, ngeoffray@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30456

[Lasse Reichstein Nielsen, 2013-11-13 08:53:29]

+ngeoffray.

[floitsch, 2013-11-18 10:48:31]

LGTM with some nits.

https://codereview.chromium.org/70263002/diff/1/sdk/lib/_internal/lib/isolate...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/70263002/diff/1/sdk/lib/_internal/lib/isolate...
sdk/lib/_internal/lib/isolate_helper.dart:951:
_globalState.currentContext.unregister(_id);
Since the ReceivePortBase registers, it should also be the ReceivePortBase that
unregisters.

https://codereview.chromium.org/70263002/diff/1/sdk/lib/_internal/lib/isolate...
sdk/lib/_internal/lib/isolate_helper.dart:959: SendPort get sendPort {
Should be in base clase.

https://codereview.chromium.org/70263002/diff/1/tests/isolate/raw_port_test.dart
File tests/isolate/raw_port_test.dart (right):

https://codereview.chromium.org/70263002/diff/1/tests/isolate/raw_port_test.d...
tests/isolate/raw_port_test.dart:7: library raw_port_test;
Test doesn't work in Dartium (because of spawn). Make sure to update the status
file.

[Lasse Reichstein Nielsen, 2013-11-18 15:45:36]

https://codereview.chromium.org/70263002/diff/1/sdk/lib/_internal/lib/isolate...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/70263002/diff/1/sdk/lib/_internal/lib/isolate...
sdk/lib/_internal/lib/isolate_helper.dart:951:
_globalState.currentContext.unregister(_id);
On 2013/11/18 10:48:31, floitsch wrote:
> Since the ReceivePortBase registers, it should also be the ReceivePortBase
that
> unregisters.

Done.

https://codereview.chromium.org/70263002/diff/1/tests/isolate/raw_port_test.dart
File tests/isolate/raw_port_test.dart (right):

https://codereview.chromium.org/70263002/diff/1/tests/isolate/raw_port_test.d...
tests/isolate/raw_port_test.dart:7: library raw_port_test;
On 2013/11/18 10:48:31, floitsch wrote:
> Test doesn't work in Dartium (because of spawn). Make sure to update the
status
> file.

Done.

[ngeoffray, 2013-11-19 07:43:41]

DBC

https://codereview.chromium.org/70263002/diff/1/tests/isolate/raw_port_test.dart
File tests/isolate/raw_port_test.dart (right):

https://codereview.chromium.org/70263002/diff/1/tests/isolate/raw_port_test.d...
tests/isolate/raw_port_test.dart:1: // Copyright (c) 2012, the Dart project
authors.  Please see the AUTHORS file
2012 -> 2013

https://codereview.chromium.org/70263002/diff/80001/sdk/lib/_internal/lib/iso...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/70263002/diff/80001/sdk/lib/_internal/lib/iso...
sdk/lib/_internal/lib/isolate_helper.dart:862: class ReceivePortBase {
The fact that this is extended and implemented seems off with the handling of
nextFreeId and id.

[Lasse Reichstein Nielsen, 2013-11-19 09:45:33]

https://codereview.chromium.org/70263002/diff/80001/sdk/lib/_internal/lib/iso...
File sdk/lib/_internal/lib/isolate_helper.dart (right):

https://codereview.chromium.org/70263002/diff/80001/sdk/lib/_internal/lib/iso...
sdk/lib/_internal/lib/isolate_helper.dart:862: class ReceivePortBase {
Yes. I need to extend both Stream and ReceivePortBase, and neither of them are
usable as a Mixin, so I'm stuck, and have to implement one of them.

Maybe I should make a ReceivePortMixin instead, and require the constructor to
call "_init".

[Lasse Reichstein Nielsen, 2013-11-20 08:37:31]

PTAL Nicolas.

[Lasse Reichstein Nielsen, 2013-11-20 10:11:19]

PTAL again.

[ngeoffray, 2013-11-20 10:16:30]

LGTM. Much simpler.

https://codereview.chromium.org/70263002/diff/180001/sdk/lib/_internal/lib/is...
File sdk/lib/_internal/lib/isolate_patch.dart (right):

https://codereview.chromium.org/70263002/diff/180001/sdk/lib/_internal/lib/is...
sdk/lib/_internal/lib/isolate_patch.dart:11: ReceivePortWrapper,
Remove ReceivePortWrapper.

https://codereview.chromium.org/70263002/diff/180001/sdk/lib/isolate/isolate....
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/70263002/diff/180001/sdk/lib/isolate/isolate....
sdk/lib/isolate/isolate.dart:211: * Returns a send port that sends to this
receive port.
a send port -> a [SendPort].

[floitsch, 2013-11-20 10:23:55]

LGTM.

[Lasse Reichstein Nielsen, 2013-11-20 10:35:26]

https://codereview.chromium.org/70263002/diff/180001/sdk/lib/_internal/lib/is...
File sdk/lib/_internal/lib/isolate_patch.dart (right):

https://codereview.chromium.org/70263002/diff/180001/sdk/lib/_internal/lib/is...
sdk/lib/_internal/lib/isolate_patch.dart:11: ReceivePortWrapper,
On 2013/11/20 10:16:30, ngeoffray wrote:
> Remove ReceivePortWrapper.

Done.

https://codereview.chromium.org/70263002/diff/180001/sdk/lib/isolate/isolate....
File sdk/lib/isolate/isolate.dart (right):

https://codereview.chromium.org/70263002/diff/180001/sdk/lib/isolate/isolate....
sdk/lib/isolate/isolate.dart:211: * Returns a send port that sends to this
receive port.
On 2013/11/20 10:16:30, ngeoffray wrote:
> a send port -> a [SendPort].

Done.

[Lasse Reichstein Nielsen, 2013-11-20 10:36:51]

Committed patchset #5 manually as r30456 (presubmit successful).