Issue 702423002: Revert "Drop trailing null arguments in generated JS."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 702423002: Revert "Drop trailing null arguments in generated JS." (Closed)

Created:
6 years, 1 month ago by herhut

Modified:
6 years, 1 month ago

Reviewers:
sigurdm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Drop trailing null arguments in generated JS." This reverts revision 41555. BUG= TBR=sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41560

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -60 lines)			Patch
	M	pkg/compiler/lib/src/ssa/codegen.dart	View		3 chunks	+6 lines, -28 lines	0 comments	Download
	D	tests/compiler/dart2js/drop_trailing_null_arguments_test.dart	View		1 chunk	+0 lines, -32 lines	0 comments	Download

Total messages: 3 (0 generated)

herhut

Committed patchset #1 (id:1) manually as 41560 (presubmit successful).

6 years, 1 month ago (2014-11-06 14:18:17 UTC) #1

Message was sent while issue was closed.

lgtm