Fix a bug in the handling of Phi nodes.

Fix a bug in the handling of Phi nodes.

BUG= http://dartbug.com/21351
R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41480

[herhut, 2014-11-04 09:28:51]

herhut@google.com changed reviewers:
+ karlklose@google.com

[herhut, 2014-11-04 09:30:19]

The addition of allocateLoopPhi is not necessary to fix the bug but makes the
[isLoop] flag in PhiTypeInformation nodes more correct. I found that helpful
during debugging. Currently, there is no other use of that flag but that might
change soon.

[karlklose, 2014-11-04 09:47:04]

LGTM.

https://codereview.chromium.org/701793002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
(right):

https://codereview.chromium.org/701793002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart:454:
PhiElementTypeInformation result =
Consider adding a helper
  _addPhi(member, node, isLoop, variable, inputType) {
    var result = new PhiElementTypeInformation(currentMember, node, 
        isLoop, variable);
    allocatedTypes.add(result);
    result.addAssignment(inputType);
    return result;
  }
and use it in allocatePhi and allocateLoopPhi.

[herhut, 2014-11-04 10:12:56]

Patchset #2 (id:20001) has been deleted

[herhut, 2014-11-04 10:14:34]

Patchset #2 (id:40001) has been deleted

[herhut, 2014-11-04 10:15:40]

I have also moved the test to dart2js_extra.

https://codereview.chromium.org/701793002/diff/1/sdk/lib/_internal/compiler/i...
File sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
(right):

https://codereview.chromium.org/701793002/diff/1/sdk/lib/_internal/compiler/i...
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart:454:
PhiElementTypeInformation result =
On 2014/11/04 09:47:04, karlklose wrote:
> Consider adding a helper
>   _addPhi(member, node, isLoop, variable, inputType) {
>     var result = new PhiElementTypeInformation(currentMember, node, 
>         isLoop, variable);
>     allocatedTypes.add(result);
>     result.addAssignment(inputType);
>     return result;
>   }
> and use it in allocatePhi and allocateLoopPhi.

Done.

[karlklose, 2014-11-04 10:20:26]

On 2014/11/04 10:15:40, herhut wrote:
> I have also moved the test to dart2js_extra.
> 
>
https://codereview.chromium.org/701793002/diff/1/sdk/lib/_internal/compiler/i...
> File
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart
> (right):
> 
>
https://codereview.chromium.org/701793002/diff/1/sdk/lib/_internal/compiler/i...
>
sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart:454:
> PhiElementTypeInformation result =
> On 2014/11/04 09:47:04, karlklose wrote:
> > Consider adding a helper
> >   _addPhi(member, node, isLoop, variable, inputType) {
> >     var result = new PhiElementTypeInformation(currentMember, node, 
> >         isLoop, variable);
> >     allocatedTypes.add(result);
> >     result.addAssignment(inputType);
> >     return result;
> >   }
> > and use it in allocatePhi and allocateLoopPhi.
> 
> Done.

SLGTM.

[herhut, 2014-11-04 10:26:38]

Committed patchset #2 (id:60001) manually as 41480 (presubmit successful).