Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 701583003: Workaround for ConstantVisitor dependency issues. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Workaround for ConstantVisitor dependency issues. This restores proper test functionality on the buildbots. I plan to follow up with a more permanent fix. BUG=dartbug.com/21572 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41676

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -9 lines) Patch
M pkg/analysis_server/test/services/refactoring/extract_local_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 2 chunks +12 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 2 chunks +32 lines, -0 lines 0 comments Download
M pkg/docgen/lib/src/models/annotation.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-11 22:23:56 UTC) #2
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-11 22:46:28 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-11 22:56:07 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41676 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698