Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(696)

Issue 701413002: Re-land r41544 "Update dart binaries used for running tests to version 1.7.2" (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Re-land r41544 "Update dart binaries used for running tests to version 1.7.2" This also re-lands r41546, and some status file updates. BUG=dartbug.com/21525 21526 21527 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41562

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -21 lines) Patch
M tests/co19/co19-dartium.status View 2 chunks +18 lines, -15 lines 0 comments Download
M tests/html/html.status View 3 chunks +5 lines, -0 lines 1 comment Download
M tests/html/xhr_test.dart View 1 chunk +5 lines, -4 lines 0 comments Download
M tools/testing/bin/linux/dart View Binary file 0 comments Download
M tools/testing/bin/linux/dart-arm View Binary file 0 comments Download
M tools/testing/bin/linux/dart-mips View Binary file 0 comments Download
M tools/testing/bin/macos/dart View Binary file 0 comments Download
M tools/testing/bin/windows/dart.exe View Binary file 0 comments Download
M tools/testing/dart/http_server.dart View 3 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bill Hesse
6 years, 1 month ago (2014-11-06 14:59:00 UTC) #2
ricow1
lgtm https://codereview.chromium.org/701413002/diff/1/tests/html/html.status File tests/html/html.status (right): https://codereview.chromium.org/701413002/diff/1/tests/html/html.status#newcode358 tests/html/html.status:358: [ $runtime == dartium && ($system == macos ...
6 years, 1 month ago (2014-11-06 15:09:44 UTC) #3
Bill Hesse
6 years, 1 month ago (2014-11-06 15:29:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41562 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698