Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Issue 701123002: Support local functions in analyzer2dart. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry, sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support local functions in analyzer2dart. BUG= R=paulberry@google.com, sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41600

Patch Set 1 #

Total comments: 2

Patch Set 2 : Updated cf. comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+308 lines, -59 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 3 chunks +63 lines, -3 lines 0 comments Download
M pkg/analyzer2dart/lib/src/element_converter.dart View 1 chunk +5 lines, -1 line 0 comments Download
M pkg/analyzer2dart/lib/src/modely.dart View 3 chunks +45 lines, -10 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_data.dart View 1 chunk +50 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 1 chunk +76 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 6 chunks +55 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 2 chunks +14 lines, -41 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-11-05 13:19:07 UTC) #2
Paul Berry
analyzer2dart parts lgtm
6 years, 1 month ago (2014-11-05 15:19:12 UTC) #3
sigurdm
lgtm https://codereview.chromium.org/701123002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/701123002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart#newcode694 pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:694: /// Create an invocation of [local] where the ...
6 years, 1 month ago (2014-11-06 11:48:30 UTC) #4
Johnni Winther
https://codereview.chromium.org/701123002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart File pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart (right): https://codereview.chromium.org/701123002/diff/1/pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart#newcode694 pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart:694: /// Create an invocation of [local] where the argument ...
6 years, 1 month ago (2014-11-07 12:07:51 UTC) #5
Johnni Winther
6 years, 1 month ago (2014-11-07 12:36:42 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41600 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698