Issue 701113004: Fix old bug in VirtualMemory::Commit on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 701113004: Fix old bug in VirtualMemory::Commit on Windows. (Closed)

Created:
6 years, 1 month ago by koda

Modified:
6 years, 1 month ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Fix old bug in VirtualMemory::Commit on Windows. This was recently exposed by VerifiedMemory, which was the first time we commit something that's not the initial part of a reservation. BUG=dart:21469 TBR=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41533

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -5 lines)			Patch
	M	runtime/tests/vm/vm.status	View		1 chunk	+0 lines, -4 lines	0 comments	Download
	M	runtime/vm/virtual_memory_win.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

koda

Committed patchset #2 (id:20001) manually as r41533 (presubmit successful).

6 years, 1 month ago (2014-11-05 21:29:58 UTC) #2

Message was sent while issue was closed.

LGTM & Thanks!

-Ivan