Issue 700753004: Refactor browser test enqueuing in test scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700753004: Refactor browser test enqueuing in test scripts. (Closed)

Created:
6 years, 1 month ago by Bill Hesse

Modified:
6 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Refactor browser test enqueuing in test scripts. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41633

Patch Set 2 : Fix errors. #

Total comments: 1

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+282 lines, -225 lines)			Patch
M	tests/html/html.status	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	tests/html/no_linked_scripts_htmltest.html	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/testing/dart/test_suite.dart	View	1	2 chunks	+279 lines, -221 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

https://codereview.chromium.org/700753004/diff/20001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/700753004/diff/20001/tools/testing/dart/test_suite.dart#newcode1388 tools/testing/dart/test_suite.dart:1388: } while (subtestIndex < subtestNames.length); maybe change this to ...

6 years, 1 month ago (2014-11-10 11:46:36 UTC) #4

Bill Hesse

6 years, 1 month ago (2014-11-10 13:37:49 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as 41633 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Issue 700753004: Refactor browser test enqueuing in test scripts. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix errors. #

Messages