Issue 70073004: Revert "Retain types of toplevel and instance variables for reflection."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 70073004: Revert "Retain types of toplevel and instance variables for reflection." (Closed)

Created:
7 years, 1 month ago by zarah

Modified:
7 years, 1 month ago

Reviewers:
Johnni Winther, karlklose

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Revert "Retain types of toplevel and instance variables for reflection." This reverts commit r30220. Committed: https://code.google.com/p/dart/source/detail?r=30222

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+42 lines, -121 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_emitter/class_emitter.dart	View	1 chunk	+1 line, -5 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/js_emitter/declarations.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_mirrors.dart	View	7 chunks	+23 lines, -28 lines	0 comments	Download
M	tests/lib/lib.status	View	2 chunks	+5 lines, -2 lines	0 comments	Download
D	tests/lib/mirrors/field_type_test.dart	View	1 chunk	+0 lines, -76 lines	0 comments	Download
M	tests/lib/mirrors/generic_type_mirror_test.dart	View	2 chunks	+4 lines, -4 lines	0 comments	Download

Total messages: 3 (0 generated)

zarah

Committed patchset #1 manually as r30222 (presubmit successful).

7 years, 1 month ago (2013-11-13 10:05:06 UTC) #1

Message was sent while issue was closed.

lgtm :(