Issue 70073003: Combine unmodifiable_collection package into collection_helpers.

Issue 70073003: Combine unmodifiable_collection package into collection_helpers. (Closed)

Created:
7 years, 1 month ago by Lasse Reichstein Nielsen

Modified:
7 years, 1 month ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Combine unmodifiable_collection package into collection_helpers. Avoids some duplicated code, and makes everything much simpler. R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=30402

Patch Set 1 #

Patch Set 2 : Include the test. #

Patch Set 3 : Update some documentation. #

Total comments: 4

Patch Set 4 : Address comments. Remove references from other packages. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -1160 lines)			Patch
M	pkg/args/lib/args.dart	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	pkg/args/lib/src/options.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/args/pubspec.yaml	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/collection_helpers/lib/algorithms.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/collection_helpers/lib/all.dart	View	1 2 3	1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/collection_helpers/lib/equality.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/collection_helpers/lib/unmodifiable_wrappers.dart	View	1 2 3	5 chunks	+31 lines, -144 lines	0 comments	Download
M	pkg/collection_helpers/lib/wrappers.dart	View		1 chunk	+9 lines, -1 line	0 comments	Download
M	pkg/collection_helpers/pubspec.yaml	View		1 chunk	+1 line, -1 line	0 comments	Download
A +	pkg/collection_helpers/test/unmodifiable_collection_test.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/logging/lib/logging.dart	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/logging/pubspec.yaml	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
D	pkg/unmodifiable_collection/lib/unmodifiable_collection.dart	View		1 chunk	+0 lines, -364 lines	0 comments	Download
D	pkg/unmodifiable_collection/pubspec.yaml	View		1 chunk	+0 lines, -10 lines	0 comments	Download
D	pkg/unmodifiable_collection/test/unmodifiable_collection_test.dart	View		1 chunk	+0 lines, -629 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Lasse Reichstein Nielsen

Also removes package:unmodifiable_collection

7 years, 1 month ago (2013-11-12 18:53:57 UTC) #1

floitsch

LGTM. https://codereview.chromium.org/70073003/diff/70001/pkg/collection_helpers/lib/all.dart File pkg/collection_helpers/lib/all.dart (right): https://codereview.chromium.org/70073003/diff/70001/pkg/collection_helpers/lib/all.dart#newcode13 pkg/collection_helpers/lib/all.dart:13: * Includes unmodifiable views of a collection. views ...

7 years, 1 month ago (2013-11-18 18:21:28 UTC) #2

Lasse Reichstein Nielsen

Committed patchset #4 manually as r30402 (presubmit successful).

7 years, 1 month ago (2013-11-19 12:11:41 UTC) #3

Lasse Reichstein Nielsen

7 years, 1 month ago (2013-11-19 12:11:44 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/70073003/diff/70001/pkg/collection_helpers/li...
File pkg/collection_helpers/lib/all.dart (right):

https://codereview.chromium.org/70073003/diff/70001/pkg/collection_helpers/li...
pkg/collection_helpers/lib/all.dart:13: *                    Includes
unmodifiable views of a collection.
On 2013/11/18 18:21:29, floitsch wrote:
> views of collections.

Done.

https://codereview.chromium.org/70073003/diff/70001/pkg/collection_helpers/li...
File pkg/collection_helpers/lib/unmodifiable_wrappers.dart (right):

https://codereview.chromium.org/70073003/diff/70001/pkg/collection_helpers/li...
pkg/collection_helpers/lib/unmodifiable_wrappers.dart:6: * Wrappers that prevent
a List, Set, or Map objects from being modified.
On 2013/11/18 18:21:29, floitsch wrote:
> object-s-

Done.

Expand Messages | Collapse Messages