Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(790)

Issue 700163002: Fix import in compile_loop.dart. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix import in compile_loop.dart. BUG= R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=41554

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/compiler/samples/compile_loop/compile_loop.dart View 1 chunk +1 line, -1 line 2 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-11-05 13:43:09 UTC) #2
ahe
lgtm https://codereview.chromium.org/700163002/diff/1/pkg/compiler/samples/compile_loop/compile_loop.dart File pkg/compiler/samples/compile_loop/compile_loop.dart (right): https://codereview.chromium.org/700163002/diff/1/pkg/compiler/samples/compile_loop/compile_loop.dart#newcode11 pkg/compiler/samples/compile_loop/compile_loop.dart:11: import '../../lib/compiler.dart' as compiler; Would 'package:compiler/compiler.dart' work?
6 years, 1 month ago (2014-11-05 14:24:44 UTC) #3
Johnni Winther
https://codereview.chromium.org/700163002/diff/1/pkg/compiler/samples/compile_loop/compile_loop.dart File pkg/compiler/samples/compile_loop/compile_loop.dart (right): https://codereview.chromium.org/700163002/diff/1/pkg/compiler/samples/compile_loop/compile_loop.dart#newcode11 pkg/compiler/samples/compile_loop/compile_loop.dart:11: import '../../lib/compiler.dart' as compiler; On 2014/11/05 14:24:43, ahe wrote: ...
6 years, 1 month ago (2014-11-06 08:15:56 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-11-06 13:17:55 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41554 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698