dart2js: Don't emit additional precompiled file.

dart2js: Don't emit additional precompiled file.

R=johnniwinther@google.com, rnystrom@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41657
Reverted: https://code.google.com/p/dart/source/detail?r=41659

Committed: https://code.google.com/p/dart/source/detail?r=41711

[floitsch, 2014-11-05 09:57:00]

floitsch@google.com changed reviewers:
+ johnniwinther@google.com

[floitsch, 2014-11-05 09:57:01]

I intend to commit this CL early next week.

[Johnni Winther, 2014-11-05 10:33:21]

lgtm

[floitsch, 2014-11-11 09:47:14]

Committed patchset #1 (id:1) manually as 41657 (presubmit successful).

[floitsch, 2014-11-11 13:18:54]

floitsch@google.com changed reviewers:
+ rnystrom@google.com

[floitsch, 2014-11-11 13:18:54]

@Bob: I updated the pub tests. After this CL they expected too many files.

PTAL.

[Bob Nystrom, 2014-11-11 17:17:41]

You'll want to hand-edit the non-generated versions and then re-generate these
pub sources. Just make your changes in lib/sdk/_internal/pub. Then run the pub
shell script in sdk/bin/ and it will implicitly re-run the async-await compiler
for you.

After that, check in both the generated and hand-edited changes.

Sorry for the annoying workflow. It will get simpler once async-await is
natively supported.

Thanks!

[floitsch, 2014-11-12 15:44:41]

Can't you mark the generated files as read-only to avoid this?

PTAL.

[Bob Nystrom, 2014-11-12 17:30:09]

LGTM. Sorry for the annoyance here.

> Can't you mark the generated files as read-only to avoid this?

I don't think dart:io has an API for overwriting read-only files and the
async-await compiler obviously does need to modify these.

I tried to keep the workflow as simple as possible. You just have to know not to
touch the "pub_generated" stuff and run pub at least once after you make a
change. (I originally had the pub tests also run the compiler, but the perf was
pretty bad.)

- bob

[floitsch, 2014-11-13 12:16:08]

Committed patchset #4 (id:60001) manually as 41711 (presubmit successful).