Issue 700033003: Enable dart2js compilation for new HTML tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 700033003: Enable dart2js compilation for new HTML tests. (Closed)

Created:
6 years, 1 month ago by Bill Hesse

Modified:
6 years, 1 month ago

Reviewers:
ricow1

CC:
reviews_dartlang.org, ricow1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable dart2js compilation for new HTML tests. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41668

Patch Set 1 #

Total comments: 2

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+44 lines, -28 lines)			Patch
M	tests/html/html.status	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	tools/testing/dart/html_test.dart	View	1 chunk	+13 lines, -2 lines	2 comments	Download
M	tools/testing/dart/test_suite.dart	View	7 chunks	+31 lines, -25 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

ricow1

lgtm https://codereview.chromium.org/700033003/diff/1/tools/testing/dart/html_test.dart File tools/testing/dart/html_test.dart (right): https://codereview.chromium.org/700033003/diff/1/tools/testing/dart/html_test.dart#newcode50 tools/testing/dart/html_test.dart:50: String jsScript = script.replaceFirst(dartExtension, '.js'); shouldn't that be ...

6 years, 1 month ago (2014-11-11 14:41:53 UTC) #3

Bill Hesse

Committed patchset #1 (id:1) manually as 41668 (presubmit successful).

6 years, 1 month ago (2014-11-11 14:59:21 UTC) #4

Bill Hesse

6 years, 1 month ago (2014-11-11 15:18:39 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/700033003/diff/1/tools/testing/dart/html_test...
File tools/testing/dart/html_test.dart (right):

https://codereview.chromium.org/700033003/diff/1/tools/testing/dart/html_test...
tools/testing/dart/html_test.dart:50: String jsScript =
script.replaceFirst(dartExtension, '.js');
On 2014/11/11 14:41:53, ricow1 wrote:
> shouldn't that be replaceLast?

dartExtension is a regexp ending in $.
There is no replaceLast.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages