Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 69933007: Add a bunch of debugging prints to the Mac OS watcher. (Closed)

Created:
7 years, 1 month ago by nweiz
Modified:
7 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a bunch of debugging prints to the Mac OS watcher. This reverts r30184, which in turn reverted r30181. It correctly detects whether it's running on a buildbot in a way that will work for the vm-mac-release bot. This is a temporary CL intended to help provide information about a test failure that's only reproducing on the build bot. It will be rolled back as soon as sufficient information is gathered. R=rnystrom@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=30205

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -3 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/watcher/lib/src/directory_watcher/mac_os.dart View 8 chunks +78 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
7 years, 1 month ago (2013-11-12 19:31:22 UTC) #1
Bob Nystrom
lgtm
7 years, 1 month ago (2013-11-12 19:33:34 UTC) #2
nweiz
7 years, 1 month ago (2013-11-12 20:08:47 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r30205 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698