Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Issue 698973005: Always check if instance method name collides with superclass static. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Always check if instance method name collides with superclass static. Previously we only did this check if nothing was overridden. Persumably that was intended as a speed optimization, since at first glance it would seem that if the instance method overrides something, then it can't possibly conflict with a static method in the superclass. However, that optimization doesn't work if the method being overridden is in an interface (in that case the superclass can still have a static method with the same name). So just go ahead and check in all cases. BUG=dartbug.com/18947 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -6 lines) Patch
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +3 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-04 19:02:57 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-11-04 19:10:13 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-04 19:31:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698