Issue 698563003: Fix for an error in the error handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 698563003: Fix for an error in the error handler. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix for an error in the error handler. We pass exception as String message. We would have caught it if we had run the server in the checked mode. Instead it failed at the JSON serialization stage. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41450

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	pkg/analysis_server/lib/src/analysis_server.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

scheglov

6 years, 1 month ago (2014-10-31 20:43:34 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41450 (presubmit successful).