Get rid of DART_SDK in pub.

Get rid of DART_SDK in pub.

BUG=https://code.google.com/p/dart/issues/detail?id=15019
R=nweiz@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30201

[nweiz, 2013-11-12 01:40:11]

A couple suggestions, otherwise lgtm.

https://codereview.chromium.org/69723004/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/69723004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/sdk.dart:28: /// Note that this is settable so
that bin/pub.dart can override this in tests.
Why make this settable as opposed to making it a getter that looks for
_PUB_TEST_SDK_VERSION? It seems unnecessary to involve bin/pub.dart here.

https://codereview.chromium.org/69723004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/sdk.dart:37: /// Parse an Eclipse-style version
number using the SDK's.
"using the SDK's version semantics"?

[Bob Nystrom, 2013-11-12 19:06:45]

https://codereview.chromium.org/69723004/diff/1/sdk/lib/_internal/pub/lib/src...
File sdk/lib/_internal/pub/lib/src/sdk.dart (right):

https://codereview.chromium.org/69723004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/sdk.dart:28: /// Note that this is settable so
that bin/pub.dart can override this in tests.
On 2013/11/12 01:40:11, nweiz wrote:
> Why make this settable as opposed to making it a getter that looks for
> _PUB_TEST_SDK_VERSION? It seems unnecessary to involve bin/pub.dart here.

For some reason, I convinced myself that looking at env vars in pub.dart was
cleaner. Changed it back.

https://codereview.chromium.org/69723004/diff/1/sdk/lib/_internal/pub/lib/src...
sdk/lib/_internal/pub/lib/src/sdk.dart:37: /// Parse an Eclipse-style version
number using the SDK's.
On 2013/11/12 01:40:11, nweiz wrote:
> "using the SDK's version semantics"?

Done.

[Bob Nystrom, 2013-11-12 19:07:09]

Committed patchset #2 manually as r30201 (presubmit successful).