Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 696123005: Rename snapshot, other user-visible parts of docgen to dartdocgen. (Closed)

Created:
6 years, 1 month ago by Alan Knight
Modified:
6 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1, Kathy Walrath
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Delete a trailing whitespace #

Patch Set 3 : Make the old docgen files just call the new ones #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -79 lines) Patch
M editor/build/build.py View 1 chunk +1 line, -1 line 2 comments Download
M pkg/docgen/bin/docgen.dart View 1 chunk +2 lines, -2 lines 0 comments Download
A + sdk/bin/dartdocgen View 0 chunks +-1 lines, --1 lines 0 comments Download
A + sdk/bin/dartdocgen.bat View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M sdk/bin/docgen View 1 2 1 chunk +2 lines, -31 lines 0 comments Download
M sdk/bin/docgen.bat View 1 2 1 chunk +2 lines, -44 lines 0 comments Download
M tools/create_sdk.py View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/docgen.gyp View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (1 generated)
Alan Knight
6 years, 1 month ago (2014-11-04 00:47:34 UTC) #2
ricow1
how about just calling the other script from the deprecated shell scripts? That way you ...
6 years, 1 month ago (2014-11-04 07:49:37 UTC) #3
Alan Knight
Just paranoid about tweaking scripts, especially for Windows, but done.
6 years, 1 month ago (2014-11-04 21:40:33 UTC) #4
Alan Knight
Committed patchset #3 (id:40001) manually as 41529 (presubmit successful).
6 years, 1 month ago (2014-11-05 20:23:15 UTC) #5
Alan Knight
Reverted in 41531. This fails in http://chromegw.corp.google.com/i/client.dart/builders/dart-editor-linux-be/builds/10958/steps/annotated_steps/logs/stdio with make -j 4 BUILDTYPE=ReleaseIA32 api_docs make: *** ...
6 years, 1 month ago (2014-11-05 21:12:04 UTC) #6
sethladd
IMO we should unify our names as much as we can, to make it easy ...
6 years, 1 month ago (2014-11-05 21:31:40 UTC) #7
ricow1
https://codereview.chromium.org/696123005/diff/40001/editor/build/build.py File editor/build/build.py (right): https://codereview.chromium.org/696123005/diff/40001/editor/build/build.py#newcode1145 editor/build/build.py:1145: CallBuildScript('release', 'ia32', 'dartdocgen') Yees, this is the gyp name ...
6 years, 1 month ago (2014-11-06 07:12:10 UTC) #8
Alan Knight
Committed patchset #3 (id:40001) manually as 41571 (presubmit successful).
6 years, 1 month ago (2014-11-06 17:15:20 UTC) #9
Alan Knight
6 years, 1 month ago (2014-11-06 17:41:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as 41573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698