Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issue 694413004: Flush analysis server output stream when closed. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Flush analysis server output stream when closed. This ensures that if the analysis server terminated with an exception, the stacktrace will actually be written to stdout before the server exits. BUG=dartbug.com/21494 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41495

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M pkg/analysis_server/lib/src/channel/byte_stream_channel.dart View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-03 23:40:39 UTC) #2
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-04 14:44:36 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-04 16:11:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41495 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698