Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issue 693793002: Make stdout/stderr async (Closed)

Created:
6 years, 1 month ago by Søren Gjesse
Modified:
6 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, vm-dev_dartlang.org, iposva, Anders Johnsen
Visibility:
Public.

Description

Make stdout/stderr async This makes stdout.write and stderr.write async. This effectively reverts https://code.google.com/p/dart/source/detail?r=33645 Reapplies r41350 after the dart2js batch-runner have been changed to handle async stdout/stderr. R=ricow@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41436

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -31 lines) Patch
M runtime/bin/stdio_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M sdk/lib/io/stdio.dart View 1 chunk +0 lines, -30 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
6 years, 1 month ago (2014-10-31 11:07:21 UTC) #1
ricow1
lgtm
6 years, 1 month ago (2014-10-31 11:43:53 UTC) #2
Søren Gjesse
6 years, 1 month ago (2014-10-31 12:12:01 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41436 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698