Issue 693693003: Resubmit fix for Function::Clone() and Field::Clone() to adjust the class owner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 693693003: Resubmit fix for Function::Clone() and Field::Clone() to adjust the class owner (Closed)

Created:
6 years, 1 month ago by regis

Modified:
6 years, 1 month ago

Reviewers:
srdjan, hausner, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Resubmit fix for Function::Clone() and Field::Clone() to adjust the class owner of type parameters (issue 18630). Make sure to clone the parameter type array as well. Add regression tests. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41474

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+166 lines, -4 lines)			Patch
M	runtime/vm/class_finalizer.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
M	runtime/vm/object.h	View	1	5 chunks	+15 lines, -0 lines	0 comments	Download
M	runtime/vm/object.cc	View	1	7 chunks	+102 lines, -3 lines	0 comments	Download
A	tests/language/mixin_type_parameter5_test.dart	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	tests/language/mixin_type_parameter6_test.dart	View		1 chunk	+17 lines, -0 lines	0 comments	Download

Total messages: 5 (2 generated)

regis

6 years, 1 month ago (2014-11-03 23:16:57 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as r41474 (presubmit successful).