Issue 69343006: Avoid regenerating unchanged bindings files for Dartium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 69343006: Avoid regenerating unchanged bindings files for Dartium. (Closed)

Created:
7 years, 1 month ago by Bill Hesse

Modified:
7 years, 1 month ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Avoid regenerating unchanged bindings files for Dartium. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=30192

Patch Set 2 : Address comments. #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	tools/dom/scripts/multiemitter.py	View	1	2 chunks	+9 lines, -9 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kustermann

LGTM with comments https://codereview.chromium.org/69343006/diff/1/tools/dom/scripts/multiemitter.py File tools/dom/scripts/multiemitter.py (right): https://codereview.chromium.org/69343006/diff/1/tools/dom/scripts/multiemitter.py#newcode94 tools/dom/scripts/multiemitter.py:94: _logger.info('Warning: File still exists- %s' % ...

7 years, 1 month ago (2013-11-12 11:47:33 UTC) #2

Bill Hesse

7 years, 1 month ago (2013-11-12 12:44:32 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r30192 (presubmit successful).

Expand Messages | Collapse Messages

Issue 69343006: Avoid regenerating unchanged bindings files for Dartium. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address comments. #

Messages