Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 693153002: Support is/as expressions in analyzer2dart. (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry, sigurdm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support is/as expressions in analyzer2dart. BUG= R=paulberry@google.com, sigurdm@google.com Committed: https://code.google.com/p/dart/source/detail?r=41438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -0 lines) Patch
M pkg/analyzer2dart/lib/src/cps_generator.dart View 1 chunk +17 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/lib/src/tree_shaker.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/end2end_data.dart View 1 chunk +36 lines, -0 lines 0 comments Download
M pkg/analyzer2dart/test/sexpr_data.dart View 1 chunk +65 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Johnni Winther
6 years, 1 month ago (2014-10-31 12:20:44 UTC) #2
sigurdm
lgtm
6 years, 1 month ago (2014-10-31 13:34:46 UTC) #3
Paul Berry
lgtm
6 years, 1 month ago (2014-10-31 13:57:14 UTC) #4
Johnni Winther
6 years, 1 month ago (2014-10-31 14:16:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41438 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698