Reapply "Port regexp tests from V8 to Dart."

Reapply "Port regexp tests from V8 to Dart."

This fixes checked mode issues and reapplies commit
https://code.google.com/p/dart/source/detail?r=41354

R=lrn@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=41416

[zerny-google, 2014-10-29 10:36:39]

The CL fixes the checked-mode issues by respectively adding type annotations to
the utils file and then satisfying them in the tests. PTAL

[Lasse Reichstein Nielsen, 2014-10-29 11:25:32]

lgtm

https://codereview.chromium.org/691473002/diff/1/tests/corelib/regexp/v8_rege...
File tests/corelib/regexp/v8_regexp_utils.dart (right):

https://codereview.chromium.org/691473002/diff/1/tests/corelib/regexp/v8_rege...
tests/corelib/regexp/v8_regexp_utils.dart:5: // Utility functions to easy
porting of V8 tests.
to->for
(or, avoiding passive tense, "to easily port v8 tests.").

https://codereview.chromium.org/691473002/diff/1/tests/corelib/regexp/v8_rege...
tests/corelib/regexp/v8_regexp_utils.dart:15: Expect.throws(fn, null, "Test
$testid failed");
Don't need to say "failed" here, this message is only written if the expectation
fails, so the failure type will be part of the full message.

https://codereview.chromium.org/691473002/diff/1/tests/corelib/regexp/v8_rege...
tests/corelib/regexp/v8_regexp_utils.dart:24: actual.add(match.group(i));
You can convert null to "" here, and avoid the "map" below.
It's also OK as is.

[zerny-google, 2014-10-30 11:31:28]

Thanks for the review.

https://codereview.chromium.org/691473002/diff/1/tests/corelib/regexp/v8_rege...
File tests/corelib/regexp/v8_regexp_utils.dart (right):

https://codereview.chromium.org/691473002/diff/1/tests/corelib/regexp/v8_rege...
tests/corelib/regexp/v8_regexp_utils.dart:5: // Utility functions to easy
porting of V8 tests.
On 2014/10/29 11:25:31, Lasse Reichstein Nielsen wrote:
> to->for
> (or, avoiding passive tense, "to easily port v8 tests.").

Done.

https://codereview.chromium.org/691473002/diff/1/tests/corelib/regexp/v8_rege...
tests/corelib/regexp/v8_regexp_utils.dart:15: Expect.throws(fn, null, "Test
$testid failed");
On 2014/10/29 11:25:31, Lasse Reichstein Nielsen wrote:
> Don't need to say "failed" here, this message is only written if the
expectation
> fails, so the failure type will be part of the full message.

Done.

https://codereview.chromium.org/691473002/diff/1/tests/corelib/regexp/v8_rege...
tests/corelib/regexp/v8_regexp_utils.dart:24: actual.add(match.group(i));
On 2014/10/29 11:25:31, Lasse Reichstein Nielsen wrote:
> You can convert null to "" here, and avoid the "map" below.
> It's also OK as is.

Done.

[zerny-google, 2014-10-30 11:34:43]

Committed patchset #2 (id:20001) manually as 41416 (presubmit successful).