Adds GN build files for building in GN based projects.

Adds GN build files for building in GN based projects.

Committed: https://code.google.com/p/dart/source/detail?r=41673

[zra, 2014-11-04 22:54:29]

zra@google.com changed reviewers:
+ iposva@google.com

[zra, 2014-11-04 22:54:29]

This change allows libraries necessary for creating Dart embedders to be built
with GN.

[zra, 2014-11-07 19:31:07]

Updated to use gypi_to_gn for file lists. PTAL.

[Ivan Posva, 2014-11-11 18:26:24]

LGTMwC

-Ivan

https://codereview.chromium.org/690923003/diff/60001/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/690923003/diff/60001/runtime/BUILD.gn#newcode30
runtime/BUILD.gn:30: # The only effect of DART_SHARED_LIB is to export the Dart
API entries.
DART_SHARED_LIB indicates whether we are building a .so or a static library. And
as you note that causes the public Dart C API entrypoints to be exported.

https://codereview.chromium.org/690923003/diff/60001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/690923003/diff/60001/runtime/bin/BUILD.gn#new...
runtime/bin/BUILD.gn:49: iolib_sources_gypi =
I find it a bit confusing that we are including the dart:io sources here, but do
not provide any of the native code. We should probably skip including these
sources.

https://codereview.chromium.org/690923003/diff/60001/runtime/bin/BUILD.gn#new...
runtime/bin/BUILD.gn:246: resources_sources_gypi =
If we do not have dart:io then including the observatory code is also
unnecessary.

https://codereview.chromium.org/690923003/diff/60001/runtime/bin/BUILD.gn#new...
runtime/bin/BUILD.gn:303: executable("dart") {
This dart binary will not be usable as it lacks the support to be loading
sources. Should we not drop it for now to avoid confusion?

https://codereview.chromium.org/690923003/diff/60001/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/690923003/diff/60001/runtime/vm/BUILD.gn#newc...
runtime/vm/BUILD.gn:111: # actions for each. After that, it generates targets to
compile the generated sources
Long line.

https://codereview.chromium.org/690923003/diff/60001/runtime/vm/BUILD.gn#newc...
runtime/vm/BUILD.gn:179: action("generate_service_cc_file") {
ditto.

Are these needed without the VM service available?

https://codereview.chromium.org/690923003/diff/60001/tools/gypi_to_gn.py
File tools/gypi_to_gn.py (right):

https://codereview.chromium.org/690923003/diff/60001/tools/gypi_to_gn.py#newc...
tools/gypi_to_gn.py:1: # Copyright 2014 The Chromium Authors. All rights
reserved.
Is the executable really necessary?

[zra, 2014-11-11 22:03:34]

Thanks!

https://codereview.chromium.org/690923003/diff/60001/runtime/BUILD.gn
File runtime/BUILD.gn (right):

https://codereview.chromium.org/690923003/diff/60001/runtime/BUILD.gn#newcode30
runtime/BUILD.gn:30: # The only effect of DART_SHARED_LIB is to export the Dart
API entries.
On 2014/11/11 18:26:23, Ivan Posva wrote:
> DART_SHARED_LIB indicates whether we are building a .so or a static library.
And
> as you note that causes the public Dart C API entrypoints to be exported.

Comment was copied from gyp. I've updated it here.

https://codereview.chromium.org/690923003/diff/60001/runtime/bin/BUILD.gn
File runtime/bin/BUILD.gn (right):

https://codereview.chromium.org/690923003/diff/60001/runtime/bin/BUILD.gn#new...
runtime/bin/BUILD.gn:49: iolib_sources_gypi =
On 2014/11/11 18:26:23, Ivan Posva wrote:
> I find it a bit confusing that we are including the dart:io sources here, but
do
> not provide any of the native code. We should probably skip including these
> sources.

Needed for gen_snapshot

https://codereview.chromium.org/690923003/diff/60001/runtime/bin/BUILD.gn#new...
runtime/bin/BUILD.gn:246: resources_sources_gypi =
On 2014/11/11 18:26:23, Ivan Posva wrote:
> If we do not have dart:io then including the observatory code is also
> unnecessary.

Removed

https://codereview.chromium.org/690923003/diff/60001/runtime/bin/BUILD.gn#new...
runtime/bin/BUILD.gn:303: executable("dart") {
On 2014/11/11 18:26:23, Ivan Posva wrote:
> This dart binary will not be usable as it lacks the support to be loading
> sources. Should we not drop it for now to avoid confusion?

Removed

https://codereview.chromium.org/690923003/diff/60001/runtime/vm/BUILD.gn
File runtime/vm/BUILD.gn (right):

https://codereview.chromium.org/690923003/diff/60001/runtime/vm/BUILD.gn#newc...
runtime/vm/BUILD.gn:111: # actions for each. After that, it generates targets to
compile the generated sources
On 2014/11/11 18:26:23, Ivan Posva wrote:
> Long line.

Done.

https://codereview.chromium.org/690923003/diff/60001/runtime/vm/BUILD.gn#newc...
runtime/vm/BUILD.gn:179: action("generate_service_cc_file") {
On 2014/11/11 18:26:23, Ivan Posva wrote:
> ditto.
> 
> Are these needed without the VM service available?

vm/service.cc refers to the symbols in the generated file, used or not

https://codereview.chromium.org/690923003/diff/60001/tools/gypi_to_gn.py
File tools/gypi_to_gn.py (right):

https://codereview.chromium.org/690923003/diff/60001/tools/gypi_to_gn.py#newc...
tools/gypi_to_gn.py:1: # Copyright 2014 The Chromium Authors. All rights
reserved.
On 2014/11/11 18:26:23, Ivan Posva wrote:
> Is the executable really necessary?

Removed the bit.

[zra, 2014-11-11 22:04:02]

Committed patchset #6 (id:100001) manually as r41673 (presubmit successful).