Issue 690513002: Fixes memory leak in Process.runSync()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 690513002: Fixes memory leak in Process.runSync() (Closed)

Created:
6 years, 1 month ago by zra

Modified:
6 years, 1 month ago

Reviewers:
Søren Gjesse, Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch, Anders Johnsen

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	runtime/bin/process_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

zra

Not sure if the call to _stdin._sink.destroy() is needed, but the non-Sync case does it.

6 years, 1 month ago (2014-10-28 22:24:22 UTC) #2

zra

6 years, 1 month ago (2014-10-28 23:02:57 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as r41378 (presubmit successful).