Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Issue 690043002: Introduce --no-prune-dead-locals flag to disable dead locals pruning. (Closed)

Created:
6 years, 1 month ago by Vyacheslav Egorov (Google)
Modified:
6 years, 1 month ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Introduce --no-prune-dead-locals flag to disable dead locals pruning. Disabling this optimization regresses code quality but improves debugging experience. R=fschneider@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41423

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M runtime/vm/flow_graph.cc View 4 chunks +6 lines, -3 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 2 chunks +6 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Vyacheslav Egorov (Google)
6 years, 1 month ago (2014-10-30 16:02:20 UTC) #1
Florian Schneider
lgtm
6 years, 1 month ago (2014-10-30 16:09:26 UTC) #2
Vyacheslav Egorov (Google)
6 years, 1 month ago (2014-10-30 16:35:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41423 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698