Issue 689793003: Rename ForEachStatement.iterator -> iterable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 689793003: Rename ForEachStatement.iterator -> iterable. (Closed)

Created:
6 years, 1 month ago by scheglov

Modified:
6 years, 1 month ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Rename ForEachStatement.iterator -> iterable. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41405

Patch Set 1 #

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+34 lines, -34 lines)			Patch
M	pkg/analysis_server/lib/src/services/correction/assist_internal.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/ast.dart	View	12 chunks	+15 lines, -15 lines	0 comments	Download
M	pkg/analyzer/lib/src/generated/parser.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/lib/src/generated/resolver.dart	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	pkg/analyzer/lib/src/services/formatter_impl.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/parser_test.dart	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/analyzer/test/generated/utilities_test.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 (id:1) manually as 41405 (presubmit successful).

6 years, 1 month ago (2014-10-29 21:33:10 UTC) #3

nweiz

6 years, 1 month ago (2014-11-19 23:55:30 UTC) #4

Message was sent while issue was closed.

On 2014/10/29 21:33:10, scheglov wrote:
> Committed patchset #1 (id:1) manually as 41405 (presubmit successful).

This change is causing compatibility problems for us. Pub is currently
preprocessed by the async_await package, which is developed outside the repo
against the latest released version of the analyzer package (currently 0.22.4).
However, we run it in the repo against the repo version, and incompatibilities
like this present serious problems. Would it be possible to retain the old
"iterator" name but mark it as deprecated and have it forward to "iterable"?

Also, as a side note, it would be really nice if you could include breaking
changes like this in the package's CHANGELOG so that your many users know what's
different between one version and the next.

Expand Messages | Collapse Messages