Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 689383005: Fix for issue 20796 (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Fixed missed case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -2 lines) Patch
M pkg/analyzer/lib/src/generated/java_core.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 5 chunks +25 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-11-07 22:41:27 UTC) #2
Brian Wilkerson
PTAL
6 years, 1 month ago (2014-11-08 00:49:22 UTC) #3
Paul Berry
lgtm
6 years, 1 month ago (2014-11-08 01:05:38 UTC) #4
Brian Wilkerson
6 years, 1 month ago (2014-11-08 04:48:51 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41622 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698