Issue 689173004: Properly implement identical() test in analyzer constant evaluation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 689173004: Properly implement identical() test in analyzer constant evaluation. (Closed)

Created:
6 years, 1 month ago by Paul Berry

Modified:
6 years, 1 month ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Properly implement identical() test in analyzer constant evaluation. Previously we were treating identical(x, y) as equivalent to (x == y). However the semantics aren't the same. BUG=dartbug.com/21177 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41475

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+237 lines, -4 lines)			Patch
M	pkg/analyzer/lib/src/generated/constant.dart	View	17 chunks	+104 lines, -1 line	0 comments	Download
M	pkg/analyzer/test/generated/all_the_rest.dart	View	2 chunks	+95 lines, -0 lines	0 comments	Download
A	tests/language/identical_const_test.dart	View	1 chunk	+37 lines, -0 lines	0 comments	Download
M	tests/language/language_analyzer.status	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/language/language_analyzer2.status	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

6 years, 1 month ago (2014-11-04 01:32:44 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as 41475 (presubmit successful).