Issue 68893017: Don't rely on a sandbox directory for pkg/path PWD tests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 68893017: Don't rely on a sandbox directory for pkg/path PWD tests. (Closed)

Created:
7 years, 1 month ago by nweiz

Modified:
7 years, 1 month ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Don't rely on a sandbox directory for pkg/path PWD tests. R=rnystrom@google.com Committed: https://code.google.com/p/dart/source/detail?r=30261

Patch Set 2 : code review #

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -7 lines)			Patch
	M	pkg/path/test/io_test.dart	View	1	1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

One suggestion then LGTM. https://codereview.chromium.org/68893017/diff/1/pkg/path/test/io_test.dart File pkg/path/test/io_test.dart (right): https://codereview.chromium.org/68893017/diff/1/pkg/path/test/io_test.dart#newcode47 pkg/path/test/io_test.dart:47: equals(path.normalize(path.join(dir, '..', 'foo/bar')))); Might as ...

7 years, 1 month ago (2013-11-14 00:37:45 UTC) #2

nweiz

https://codereview.chromium.org/68893017/diff/1/pkg/path/test/io_test.dart File pkg/path/test/io_test.dart (right): https://codereview.chromium.org/68893017/diff/1/pkg/path/test/io_test.dart#newcode47 pkg/path/test/io_test.dart:47: equals(path.normalize(path.join(dir, '..', 'foo/bar')))); On 2013/11/14 00:37:45, Bob Nystrom wrote: ...

7 years, 1 month ago (2013-11-14 00:38:32 UTC) #3

nweiz

7 years, 1 month ago (2013-11-14 00:38:48 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r30261 (presubmit successful).

Expand Messages | Collapse Messages

Issue 68893017: Don't rely on a sandbox directory for pkg/path PWD tests. (Closed)

Description

Patch Set 1 #

Patch Set 2 : code review #

Messages