Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 688663002: Support for labels in non-loop code in new dart backend (Closed)

Created:
6 years, 1 month ago by sigurdm
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, floitsch
Visibility:
Public.

Description

Support for labels in non-loop code in new dart backend Still no support for `switch` R=kmillikin@google.com Committed: https://code.google.com/p/dart/source/detail?r=41631

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add comment cf. review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -6 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_visitor.dart View 1 1 chunk +39 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/dart_backend/tree_ir_tracer.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M tests/co19/co19-dart2dart.status View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sigurdm
6 years, 1 month ago (2014-10-29 14:23:36 UTC) #3
Kevin Millikin (Google)
LGTM. https://codereview.chromium.org/688663002/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart File sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart (right): https://codereview.chromium.org/688663002/diff/20001/sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart#newcode259 sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart:259: List<ir.Parameter> parameters = Add a comment here about ...
6 years, 1 month ago (2014-11-04 13:04:07 UTC) #4
sigurdm
Committed patchset #2 (id:40001) manually as 41631 (presubmit successful).
6 years, 1 month ago (2014-11-10 13:26:17 UTC) #5
sigurdm
6 years, 1 month ago (2014-11-10 13:44:27 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/688663002/diff/20001/sdk/lib/_internal/compil...
File
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart
(right):

https://codereview.chromium.org/688663002/diff/20001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/cps_ir/cps_ir_builder_visitor.dart:259:
List<ir.Parameter> parameters =
On 2014/11/04 13:04:07, kmillikin wrote:
> Add a comment here about the scoping of the break continuation.  Something
like:
> 
> "All jumps to the break continuation must be in the scope of the
continuation's
> binding.  The continuation is bound just outside the body to satisfy this
> property without extra analysis.  As a consequence, the break continuation
needs
> parameters for all local variables in scope at the exit from the body."

Done.

Powered by Google App Engine
This is Rietveld 408576698