Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 688593005: Convert analysis starting point to an absolute path before analyzing. (Closed)

Created:
6 years, 1 month ago by Paul Berry
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Convert analysis starting point to an absolute path before analyzing. This ensures that if the analysis starting point is part of an import loop, then once the analysis engine reaches the starting point again, it will recognize that it's the same file. BUG=dartbug.com/21440 R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=41473

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M pkg/analyzer/lib/src/analyzer_impl.dart View 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
6 years, 1 month ago (2014-11-03 21:45:46 UTC) #2
Brian Wilkerson
LGTM
6 years, 1 month ago (2014-11-03 21:58:33 UTC) #3
Paul Berry
6 years, 1 month ago (2014-11-03 22:42:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41473 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698