Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(738)

Issue 688323006: Refactor test scripts browser multitest loop. (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Refactor test scripts browser multitest loop. BUG= R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41635

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -44 lines) Patch
M tools/testing/dart/test_suite.dart View 4 chunks +27 lines, -44 lines 1 comment Download

Messages

Total messages: 7 (4 generated)
Bill Hesse
6 years, 1 month ago (2014-11-10 13:35:15 UTC) #5
ricow1
lgtm https://codereview.chromium.org/688323006/diff/60001/tools/testing/dart/test_suite.dart File tools/testing/dart/test_suite.dart (right): https://codereview.chromium.org/688323006/diff/60001/tools/testing/dart/test_suite.dart#newcode1105 tools/testing/dart/test_suite.dart:1105: if (configuration['list']) { maybe copy over the existing ...
6 years, 1 month ago (2014-11-10 13:55:24 UTC) #6
Bill Hesse
6 years, 1 month ago (2014-11-10 14:26:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:60001) manually as 41635 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698