Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issue 687213002: Retry flaky tests on Safari. (Closed)

Created:
6 years, 1 month ago by Bill Hesse
Modified:
6 years, 1 month ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

_Temporarily_ retry failing browser tests on Safari, because versions 6.2 and 7.1 are flaky on dart2js output. Add support for macos 10.9 to buildbot scripts. BUG=dartbug.com/21434 R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=41394

Patch Set 1 #

Total comments: 1

Patch Set 2 : Add retry for safari. #

Total comments: 1

Patch Set 3 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M tools/bots/compiler.py View 2 chunks +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Bill Hesse
6 years, 1 month ago (2014-10-29 12:28:23 UTC) #2
ricow1
lgtm https://codereview.chromium.org/687213002/diff/1/tools/bots/compiler.py File tools/bots/compiler.py (right): https://codereview.chromium.org/687213002/diff/1/tools/bots/compiler.py#newcode29 tools/bots/compiler.py:29: r'dart2js-(ie9|ie10|ie11|ff|safari|chrome|chromeOnAndroid|safarimobilesim|opera|drt)-(win7|win8|mac10\.7|mac10\.8|mac10\.9|linux)(-(all|html))?(-(csp))?(-(\d+)-(\d+))?') delete 10.7?
6 years, 1 month ago (2014-10-29 12:30:36 UTC) #3
Bill Hesse
Added the retry to this CL.
6 years, 1 month ago (2014-10-29 12:54:23 UTC) #4
ricow1
https://codereview.chromium.org/687213002/diff/2/tools/testing/dart/test_runner.dart File tools/testing/dart/test_runner.dart (right): https://codereview.chromium.org/687213002/diff/2/tools/testing/dart/test_runner.dart#newcode2611 tools/testing/dart/test_runner.dart:2611: (command.displayName == 'dartium' || command.browser == 'safari')) { command.displayName?
6 years, 1 month ago (2014-10-29 12:57:12 UTC) #5
Bill Hesse
On 2014/10/29 12:57:12, ricow1 wrote: > https://codereview.chromium.org/687213002/diff/2/tools/testing/dart/test_runner.dart > File tools/testing/dart/test_runner.dart (right): > > https://codereview.chromium.org/687213002/diff/2/tools/testing/dart/test_runner.dart#newcode2611 > ...
6 years, 1 month ago (2014-10-29 13:02:59 UTC) #6
Bill Hesse
6 years, 1 month ago (2014-10-29 13:07:18 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:30001) manually as 41394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698