Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 687163004: Fixes leak in Process.runSync(). (Closed)

Created:
6 years, 1 month ago by zra
Modified:
6 years, 1 month ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Cutch, Anders Johnsen
Visibility:
Public.

Description

Fixes leak in Process.runSync(). This removes the call to _stdin._sink.destroy() from my previous CL, which broke a test. stdin is closed by the native implementation. Closing again shouldn't cause a problem, but it looks like destroy() attempts to do a lot more than that. OTOH adding the remove call is sufficient to fix the leak, so let's just stick with that. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=41395

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M runtime/bin/process_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
zra
6 years, 1 month ago (2014-10-29 14:07:16 UTC) #2
Ivan Posva
On 2014/10/29 14:07:16, zra wrote: LGTM - ip
6 years, 1 month ago (2014-10-29 14:31:19 UTC) #3
zra
6 years, 1 month ago (2014-10-29 14:32:33 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r41395 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698