Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1016)

Issue 686843003: add type static constants suggestions (Closed)

Created:
6 years, 1 month ago by danrubel
Modified:
6 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add type static constants suggestions BUG= R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=41369

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M pkg/analysis_server/lib/src/services/completion/invocation_computer.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 5 chunks +23 lines, -1 line 0 comments Download
M pkg/analysis_server/test/services/completion/completion_test_util.dart View 4 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
6 years, 1 month ago (2014-10-28 19:57:51 UTC) #2
scheglov
LGTM
6 years, 1 month ago (2014-10-28 20:31:32 UTC) #3
danrubel
6 years, 1 month ago (2014-10-28 21:03:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41369 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698