Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1043)

Issue 686793002: Replace EngineTestCase.assertSize() with hasLength(). (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Replace EngineTestCase.assertSize() with hasLength(). R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+646 lines, -725 lines) Patch
M pkg/analyzer/test/generated/all_the_rest.dart View 87 chunks +160 lines, -160 lines 0 comments Download
M pkg/analyzer/test/generated/ast_test.dart View 9 chunks +12 lines, -12 lines 0 comments Download
M pkg/analyzer/test/generated/element_test.dart View 28 chunks +43 lines, -43 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 43 chunks +70 lines, -70 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 148 chunks +247 lines, -247 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 43 chunks +96 lines, -96 lines 0 comments Download
M pkg/analyzer/test/generated/static_warning_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 4 chunks +1 line, -80 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 9 chunks +16 lines, -16 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-10-28 15:51:54 UTC) #1
Brian Wilkerson
LGTM. I'm assuming this was largely mechanical and I don't need to look at every ...
6 years, 1 month ago (2014-10-28 15:55:02 UTC) #2
scheglov
6 years, 1 month ago (2014-10-28 15:57:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41361 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698