Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1466)

Issue 686363002: Support globs in $include and $exclude. (Closed)

Created:
6 years, 1 month ago by nweiz
Modified:
6 years, 1 month ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Support globs in $include and $exclude. R=rnystrom@google.com BUG=17093 Committed: https://code.google.com/p/dart/source/detail?r=41476

Patch Set 1 #

Patch Set 2 : Add tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -73 lines) Patch
M sdk/lib/_internal/pub/lib/src/barback/transformer_config.dart View 6 chunks +32 lines, -17 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/exclusion/exclude_asset_glob_test.dart View 1 2 chunks +3 lines, -6 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/exclusion/exclude_asset_prefix_test.dart View 1 3 chunks +8 lines, -7 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/exclusion/include_asset_glob_test.dart View 1 2 chunks +3 lines, -6 lines 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/exclusion/include_asset_prefix_test.dart View 1 3 chunks +7 lines, -3 lines 0 comments Download
M sdk/lib/_internal/pub_generated/lib/src/barback/transformer_config.dart View 6 chunks +35 lines, -18 lines 0 comments Download
A + sdk/lib/_internal/pub_generated/test/transformer/exclusion/exclude_asset_glob_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub_generated/test/transformer/exclusion/exclude_asset_prefix_test.dart View 1 2 chunks +7 lines, -5 lines 0 comments Download
A + sdk/lib/_internal/pub_generated/test/transformer/exclusion/include_asset_glob_test.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
A + sdk/lib/_internal/pub_generated/test/transformer/exclusion/include_asset_prefix_test.dart View 1 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
6 years, 1 month ago (2014-10-30 01:32:51 UTC) #1
Bob Nystrom
LGTM, very cool! Can you file a bug on the dartlang.org GitHub repo to update ...
6 years, 1 month ago (2014-10-31 21:24:16 UTC) #2
nweiz
6 years, 1 month ago (2014-11-04 01:55:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 41476 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698