Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(269)

Issue 686113007: Report HintCode.UNUSED_LOCAL_VARIABLE for local variables whose value is never used. (Closed)

Created:
6 years, 1 month ago by scheglov
Modified:
6 years, 1 month ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Report HintCode.UNUSED_LOCAL_VARIABLE for local variables whose value is never used. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=41568

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -15 lines) Patch
M pkg/analysis_server/test/services/correction/fix_test.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/element.dart View 5 chunks +32 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 4 chunks +11 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 5 chunks +51 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 3 chunks +140 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
6 years, 1 month ago (2014-11-06 16:35:57 UTC) #1
Brian Wilkerson
LGTM. As I was looking at this I wondered whether we would want to expand ...
6 years, 1 month ago (2014-11-06 16:55:01 UTC) #2
scheglov
6 years, 1 month ago (2014-11-06 17:00:35 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41568 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698