Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 686023002: Reenable check_elements_invariants_test (Closed)

Created:
6 years, 1 month ago by Johnni Winther
Modified:
6 years ago
Reviewers:
karlklose, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reenable check_elements_invariants_test BUG=http://dartbug.com/21452 R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=42131

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Update test #

Patch Set 4 : Update status correctly. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -18 lines) Patch
M tests/compiler/dart2js/check_elements_invariants_test.dart View 1 2 4 chunks +5 lines, -16 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Johnni Winther
6 years, 1 month ago (2014-10-29 08:25:04 UTC) #2
Johnni Winther
ping
6 years, 1 month ago (2014-11-06 08:53:16 UTC) #3
Johnni Winther
6 years, 1 month ago (2014-11-18 14:36:21 UTC) #5
karlklose
LGTM, sorry for the delay.
6 years ago (2014-11-25 13:33:07 UTC) #6
Johnni Winther
6 years ago (2014-12-05 09:08:39 UTC) #7
Message was sent while issue was closed.
Committed patchset #4 (id:60001) manually as 42131 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698