Make table entries on analysis server's '/status' page clickable.

Make table entries on analysis server's '/status' page clickable.

Clicking on a table entry now takes you to a list of files in the
given state.

R=brianwilkerson@google.com

Committed: https://code.google.com/p/dart/source/detail?r=41400

[Paul Berry, 2014-10-28 23:20:16]

paulberry@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2014-10-29 13:51:02]

I like the functionality, but have some concerns with the implementation.

https://codereview.chromium.org/685863003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/get_handler.dart (right):

https://codereview.chromium.org/685863003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/get_handler.dart:158: response.write('<p>$count
files found</p>');
Need to terminate the <ul> tag.

https://codereview.chromium.org/685863003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/685863003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:855: void visitCacheItems(void
callback(Source source, SourceEntry dartEntry,
AnalysisContext represents the public API, and I really don't want this method
in the public API.

There is an internal interface named InternalAnalysisContext, but the way
everything else has been done is by adding information to
AnalysisContextStatisticsImpl. One of the reasons for that choice was to avoid
synchronization issues, which presumably isn't important any more, so perhaps it
should be rethought.

If we do go with a general access mechanism, I think it would be better to have

  void visitCacheItems(void callback(Source source, SourceEntry entry));

Most clients don't need to visit a single entry more than once, so this would be
more efficient.

https://codereview.chromium.org/685863003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:5227: static const List<CacheState>
STATES = const <CacheState>[
Use CacheState.values instead?

[Paul Berry, 2014-10-29 18:39:11]

https://codereview.chromium.org/685863003/diff/1/pkg/analysis_server/lib/src/...
File pkg/analysis_server/lib/src/get_handler.dart (right):

https://codereview.chromium.org/685863003/diff/1/pkg/analysis_server/lib/src/...
pkg/analysis_server/lib/src/get_handler.dart:158: response.write('<p>$count
files found</p>');
On 2014/10/29 13:51:02, Brian Wilkerson wrote:
> Need to terminate the <ul> tag.

Done.

https://codereview.chromium.org/685863003/diff/1/pkg/analyzer/lib/src/generat...
File pkg/analyzer/lib/src/generated/engine.dart (right):

https://codereview.chromium.org/685863003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:855: void visitCacheItems(void
callback(Source source, SourceEntry dartEntry,
On 2014/10/29 13:51:02, Brian Wilkerson wrote:
> AnalysisContext represents the public API, and I really don't want this method
> in the public API.
> 
> There is an internal interface named InternalAnalysisContext, but the way
> everything else has been done is by adding information to
> AnalysisContextStatisticsImpl. One of the reasons for that choice was to avoid
> synchronization issues, which presumably isn't important any more, so perhaps
it
> should be rethought.
> 
> If we do go with a general access mechanism, I think it would be better to
have
> 
>   void visitCacheItems(void callback(Source source, SourceEntry entry));
> 
> Most clients don't need to visit a single entry more than once, so this would
be
> more efficient.

Ok.  As discussed in person, I've moved this function to the
InternalAnalysisContext class for now.  We can work on the other proposed
improvements in future CL's.

https://codereview.chromium.org/685863003/diff/1/pkg/analyzer/lib/src/generat...
pkg/analyzer/lib/src/generated/engine.dart:5227: static const List<CacheState>
STATES = const <CacheState>[
On 2014/10/29 13:51:02, Brian Wilkerson wrote:
> Use CacheState.values instead?

Done.

[Brian Wilkerson, 2014-10-29 18:39:47]

LGTM once verbally discussed change is made

[Paul Berry, 2014-10-29 20:05:21]

Committed patchset #2 (id:20001) manually as 41400 (presubmit successful).