Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 685123006: Status page improvements (Closed)

Created:
6 years, 1 month ago by Brian Wilkerson
Modified:
6 years, 1 month ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Status page improvements: sort context names, right align numbers, add missing data descriptors. R=paulberry@google.com Committed: https://code.google.com/p/dart/source/detail?r=41427

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -17 lines) Patch
M pkg/analysis_server/lib/src/get_handler.dart View 5 chunks +40 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 3 chunks +18 lines, -3 lines 2 comments Download

Messages

Total messages: 5 (1 generated)
Brian Wilkerson
6 years, 1 month ago (2014-10-30 00:48:27 UTC) #2
Paul Berry
lgtm https://codereview.chromium.org/685123006/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/685123006/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode1640 pkg/analyzer/lib/src/generated/engine.dart:1640: // handleCacheItem(source, dartEntry, DartEntry.CONTAINING_LIBRARIES); It would be nice ...
6 years, 1 month ago (2014-10-30 17:36:52 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/685123006/diff/1/pkg/analyzer/lib/src/generated/engine.dart File pkg/analyzer/lib/src/generated/engine.dart (right): https://codereview.chromium.org/685123006/diff/1/pkg/analyzer/lib/src/generated/engine.dart#newcode1640 pkg/analyzer/lib/src/generated/engine.dart:1640: // handleCacheItem(source, dartEntry, DartEntry.CONTAINING_LIBRARIES); Done
6 years, 1 month ago (2014-10-30 21:06:59 UTC) #4
Brian Wilkerson
6 years, 1 month ago (2014-10-30 21:11:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 41427 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698