Land VERSION dependency for dart2js and dartdoc snapshot generation

Land VERSION dependency for dart2js and dartdoc snapshot generation

R=kustermann@google.com

Committed: https://code.google.com/p/dart/source/detail?r=30144

[kustermann, 2013-11-11 08:23:05]

LGTM

[ricow1, 2013-11-11 08:23:14]

Peter, just fyi

[ahe, 2013-11-11 08:31:27]

How is tools/VERSION modified?

[ricow1, 2013-11-11 08:38:04]

On 2013/11/11 08:31:27, ahe wrote:
> How is tools/VERSION modified?

I modify tools/VERSION on every push or cherry-pick to trunk or branches

[ricow1, 2013-11-11 08:53:10]

Committed patchset #2 manually as r30144 (presubmit successful).

[ahe, 2013-11-11 08:53:58]

On 2013/11/11 08:38:04, ricow1 wrote:
> On 2013/11/11 08:31:27, ahe wrote:
> > How is tools/VERSION modified?
> 
> I modify tools/VERSION on every push or cherry-pick to trunk or branches

So it is manually modified?

[kustermann, 2013-11-11 08:57:24]

Yes. Every commit to trunk or stable channel will increment the build number.

[ahe, 2013-11-11 09:04:38]

On 2013/11/11 08:57:24, kustermann wrote:
> Yes. Every commit to trunk or stable channel will increment the build number.

My understanding is that the file tools/VERSION is manually modified. That seems
right.

Now it sounds like the file is automatically updated, which seems problematic.

[kustermann, 2013-11-11 09:36:38]

It's not automatically updated. Every *commit* to trunk or stable channel
*should contain* a change to tools/VERSION (the committer has to make sure that
the VERSION file is changed).

In the past it has sometimes occurred that VERSION was not updated by a commit
on trunk/stable channel which caused issues (we *could* add a check to the
presubmit script for that).

[ahe, 2013-11-11 09:51:19]

lgtm